#5 - Remove UI /rpc proxy handler — hero_router owns /rpc - lhumina_code/hero_livekit

mahmoud commented

2026-04-19 21:17:46 +00:00

Owner

Context

crates/hero_livekit_ui/src/main.rs:109,264-302 defines route("/rpc", post(rpc_proxy_handler)) and a custom forward_rpc that forwards JSON-RPC to the server UDS. Per hero_crates_best_practices_check §Forbidden behaviors and hero_ui_openrpc_proxy, hero_router owns the /rpc path — individual UIs must not implement their own proxy. The browser should hit /<service>/rpc/ through hero_router directly; the Rust backend uses the SDK (#${sdk_issue}) for server-side aggregation.

Goals

Delete rpc_proxy_handler and its /rpc route in crates/hero_livekit_ui/src/main.rs.
Delete the supporting forward_rpc helper.
Update templates/ JavaScript so any fetch to /rpc is instead /${X-Forwarded-Prefix}/rpc/ (hero_router-mediated).
Verify UI still renders by exercising the dashboard under hero_router.

Related skills: hero_ui_openrpc_proxy, hero_router, hero_crates_best_practices_check.

## Context `crates/hero_livekit_ui/src/main.rs:109,264-302` defines `route("/rpc", post(rpc_proxy_handler))` and a custom `forward_rpc` that forwards JSON-RPC to the server UDS. Per `hero_crates_best_practices_check` §Forbidden behaviors and `hero_ui_openrpc_proxy`, **hero_router owns the `/rpc` path** — individual UIs must not implement their own proxy. The browser should hit `/<service>/rpc/` through hero_router directly; the Rust backend uses the SDK (#${sdk_issue}) for server-side aggregation. ## Goals - Delete `rpc_proxy_handler` and its `/rpc` route in `crates/hero_livekit_ui/src/main.rs`. - Delete the supporting `forward_rpc` helper. - Update `templates/` JavaScript so any fetch to `/rpc` is instead `/${X-Forwarded-Prefix}/rpc/` (hero_router-mediated). - Verify UI still renders by exercising the dashboard under hero_router. Related skills: `hero_ui_openrpc_proxy`, `hero_router`, `hero_crates_best_practices_check`.

ashraf commented

2026-04-23 13:19:09 +00:00

Member

Implementation Spec for Issue #5

Objective

Remove the custom /rpc JSON-RPC proxy handler from hero_livekit_ui so that all browser RPC traffic flows through hero_router directly to the server's rpc.sock, in compliance with the rule that hero_router owns the /rpc path.

Requirements

Delete rpc_proxy_handler function and its /rpc route from main.rs
Delete the supporting forward_rpc helper function
Clean up dead imports (AsyncReadExt, AsyncWriteExt)
Update dashboard.js fetch URL from "/rpc" to "/rpc/" for hero_router convention
Update documentation to remove /rpc passthrough references
Update template comments

Files to Modify

crates/hero_livekit_ui/src/main.rs - Delete rpc_proxy_handler, forward_rpc, /rpc route, dead imports, update doc-comment
crates/hero_livekit_ui/static/js/dashboard.js - Change fetch URL from "/rpc" to "/rpc/"
crates/hero_livekit_ui/templates/base.html - Update comment removing /rpc reference
docs/architecture.md - Update process table and request flow diagrams
docs/ui.md - Remove /rpc route from routes table, update base-path docs

Implementation Plan

Step 1: Remove Rust proxy code from main.rs

Files: crates/hero_livekit_ui/src/main.rs

Delete doc-comment line referencing POST /rpc
Delete use tokio::io::{AsyncReadExt, AsyncWriteExt}; import
Delete .route("/rpc", post(rpc_proxy_handler)) from router
Delete rpc_proxy_handler function (including comment)
Delete forward_rpc function
Dependencies: none

Step 2: Update JavaScript and template

Files: crates/hero_livekit_ui/static/js/dashboard.js, crates/hero_livekit_ui/templates/base.html

In dashboard.js, change fetch(BASE + "/rpc", { to fetch(BASE + "/rpc/", {
In base.html, update comment to remove /rpc reference
Dependencies: none

Step 3: Update documentation

Files: docs/architecture.md, docs/ui.md

Update process table (remove "/rpc passthrough" from hero_livekit_ui description)
Update request flow diagrams (browser goes directly to rpc.sock via hero_router)
Remove /rpc route from UI routes table
Update base-path support paragraph
Dependencies: none

Acceptance Criteria

rpc_proxy_handler and forward_rpc completely removed from main.rs
/rpc route no longer appears in the Axum router
cargo build -p hero_livekit_ui compiles cleanly
dashboard.js uses BASE + "/rpc/" for hero_router-mediated path
Documentation no longer references the UI's /rpc passthrough

Notes

connection-status.js does not reference /rpc directly -- it receives an RPC function via the pingFn callback from dashboard.js
The start_backend_handler and UnixStream import stay -- they are used for probing rpc.sock existence
AppState.socket_path stays -- used by index_handler, join_handler, and start_backend_handler for SDK connections
When the UI is accessed directly (not via hero_router), RPC calls will return 404 -- this is intentional

## Implementation Spec for Issue #5 ### Objective Remove the custom /rpc JSON-RPC proxy handler from hero_livekit_ui so that all browser RPC traffic flows through hero_router directly to the server's rpc.sock, in compliance with the rule that hero_router owns the /rpc path. ### Requirements - Delete rpc_proxy_handler function and its /rpc route from main.rs - Delete the supporting forward_rpc helper function - Clean up dead imports (AsyncReadExt, AsyncWriteExt) - Update dashboard.js fetch URL from "/rpc" to "/rpc/" for hero_router convention - Update documentation to remove /rpc passthrough references - Update template comments ### Files to Modify - `crates/hero_livekit_ui/src/main.rs` - Delete rpc_proxy_handler, forward_rpc, /rpc route, dead imports, update doc-comment - `crates/hero_livekit_ui/static/js/dashboard.js` - Change fetch URL from "/rpc" to "/rpc/" - `crates/hero_livekit_ui/templates/base.html` - Update comment removing /rpc reference - `docs/architecture.md` - Update process table and request flow diagrams - `docs/ui.md` - Remove /rpc route from routes table, update base-path docs ### Implementation Plan #### Step 1: Remove Rust proxy code from main.rs Files: `crates/hero_livekit_ui/src/main.rs` - Delete doc-comment line referencing POST /rpc - Delete `use tokio::io::{AsyncReadExt, AsyncWriteExt};` import - Delete `.route("/rpc", post(rpc_proxy_handler))` from router - Delete rpc_proxy_handler function (including comment) - Delete forward_rpc function Dependencies: none #### Step 2: Update JavaScript and template Files: `crates/hero_livekit_ui/static/js/dashboard.js`, `crates/hero_livekit_ui/templates/base.html` - In dashboard.js, change `fetch(BASE + "/rpc", {` to `fetch(BASE + "/rpc/", {` - In base.html, update comment to remove /rpc reference Dependencies: none #### Step 3: Update documentation Files: `docs/architecture.md`, `docs/ui.md` - Update process table (remove "/rpc passthrough" from hero_livekit_ui description) - Update request flow diagrams (browser goes directly to rpc.sock via hero_router) - Remove /rpc route from UI routes table - Update base-path support paragraph Dependencies: none ### Acceptance Criteria - [ ] rpc_proxy_handler and forward_rpc completely removed from main.rs - [ ] /rpc route no longer appears in the Axum router - [ ] cargo build -p hero_livekit_ui compiles cleanly - [ ] dashboard.js uses BASE + "/rpc/" for hero_router-mediated path - [ ] Documentation no longer references the UI's /rpc passthrough ### Notes - connection-status.js does not reference /rpc directly -- it receives an RPC function via the pingFn callback from dashboard.js - The start_backend_handler and UnixStream import stay -- they are used for probing rpc.sock existence - AppState.socket_path stays -- used by index_handler, join_handler, and start_backend_handler for SDK connections - When the UI is accessed directly (not via hero_router), RPC calls will return 404 -- this is intentional

ashraf commented

2026-04-23 13:26:54 +00:00

Member

Test Results

Total: 34
Passed: 34
Failed: 0

cargo build and cargo test both succeed with no errors.

## Test Results - Total: 34 - Passed: 34 - Failed: 0 cargo build and cargo test both succeed with no errors.

ashraf commented

2026-04-23 13:27:02 +00:00

Member

Implementation Summary

Changes Made

Modified files:

crates/hero_livekit_ui/src/main.rs -- Removed rpc_proxy_handler function, forward_rpc helper, /rpc route, dead AsyncReadExt/AsyncWriteExt imports, and doc-comment reference. All other handlers and imports preserved.
crates/hero_livekit_ui/static/js/dashboard.js -- Changed RPC fetch URL from "/rpc" to "/rpc/" for hero_router trailing-slash convention.
crates/hero_livekit_ui/templates/base.html -- Updated comment to remove /rpc reference.
docs/architecture.md -- Updated process table (removed /rpc passthrough from hero_livekit_ui description) and request flow diagrams (browser now goes directly through hero_router to rpc.sock).
docs/ui.md -- Removed POST /rpc row from routes table, updated base-path docs, added clarifying note about RPC going through hero_router.

Test Results

All 34 tests pass, 0 failures.

## Implementation Summary ### Changes Made **Modified files:** - `crates/hero_livekit_ui/src/main.rs` -- Removed rpc_proxy_handler function, forward_rpc helper, /rpc route, dead AsyncReadExt/AsyncWriteExt imports, and doc-comment reference. All other handlers and imports preserved. - `crates/hero_livekit_ui/static/js/dashboard.js` -- Changed RPC fetch URL from "/rpc" to "/rpc/" for hero_router trailing-slash convention. - `crates/hero_livekit_ui/templates/base.html` -- Updated comment to remove /rpc reference. - `docs/architecture.md` -- Updated process table (removed /rpc passthrough from hero_livekit_ui description) and request flow diagrams (browser now goes directly through hero_router to rpc.sock). - `docs/ui.md` -- Removed POST /rpc row from routes table, updated base-path docs, added clarifying note about RPC going through hero_router. ### Test Results All 34 tests pass, 0 failures.