lhumina_code/hero_livekit

Fork 0

Rewrite Forgejo workflows around build_binaries/publish_binaries + ARM64 #8

New issue

Closed

opened 2026-04-19 21:17:50 +00:00 by mahmoud · 3 comments

mahmoud commented

2026-04-19 21:17:50 +00:00

Owner

Context

.forgejo/workflows/build.yml inlines all CI steps and sets continue-on-error: true on clippy (line 58), silently ignoring lint failures. .forgejo/workflows/release.yaml uploads assets via raw curl and only targets a single musl amd64 build. build_lib_ci / forge-release-workflow mandate calling build_binaries / publish_binaries from the canonical build_lib.sh and shipping ARM64 artifacts alongside AMD64.

Goals

Rewrite .forgejo/workflows/build.yml so every step runs via make <target> (make fmt-check, make clippy, make test-all); remove continue-on-error.
Rewrite .forgejo/workflows/release.yaml:
- source scripts/build_lib.sh && forge_config && build_binaries "${{ matrix.target }}" && publish_binaries "${{ matrix.artifact }}".
- Matrix entries: x86_64-unknown-linux-musl, aarch64-unknown-linux-gnu.
- Add checksum generation (sha256sum) for every asset.
Depends on the canonical build_lib.sh (issue #${build_lib_issue}).

Related skills: build_lib_ci, forge-release-workflow, forge_package.

## Context `.forgejo/workflows/build.yml` inlines all CI steps and sets `continue-on-error: true` on clippy (line 58), silently ignoring lint failures. `.forgejo/workflows/release.yaml` uploads assets via raw curl and only targets a single musl amd64 build. `build_lib_ci` / `forge-release-workflow` mandate calling `build_binaries` / `publish_binaries` from the canonical `build_lib.sh` and shipping ARM64 artifacts alongside AMD64. ## Goals - Rewrite `.forgejo/workflows/build.yml` so every step runs via `make <target>` (`make fmt-check`, `make clippy`, `make test-all`); remove `continue-on-error`. - Rewrite `.forgejo/workflows/release.yaml`: - `source scripts/build_lib.sh && forge_config && build_binaries "${{ matrix.target }}" && publish_binaries "${{ matrix.artifact }}"`. - Matrix entries: `x86_64-unknown-linux-musl`, `aarch64-unknown-linux-gnu`. - Add checksum generation (`sha256sum`) for every asset. - Depends on the canonical `build_lib.sh` (issue #${build_lib_issue}). Related skills: `build_lib_ci`, `forge-release-workflow`, `forge_package`.

ashraf commented

2026-04-23 14:23:32 +00:00

Member

Implementation Spec for Issue #8

Objective

Rewrite the two Forgejo CI workflow files (build.yml and release.yaml) to align with the canonical build_lib_ci / forge-release-workflow pattern. The build workflow must delegate all CI steps to Make targets (removing continue-on-error on clippy), and the release workflow must use build_binaries / publish_binaries from scripts/build_lib.sh with a 2-target matrix (AMD64 musl + ARM64 gnu) plus SHA-256 checksum generation.

Requirements

Build workflow: all steps invoke make <target> (fmt-check, clippy, test); remove continue-on-error
Release workflow: use build_lib.sh functions (forge_config, build_binaries, publish_binaries) with matrix
Matrix: x86_64-unknown-linux-musl (linux-amd64) + aarch64-unknown-linux-gnu (linux-arm64)
Add sha256sum checksum generation for every binary asset
Replace naive scripts/build_lib.sh with canonical version
Add .cargo/config.toml for aarch64 cross-compilation linker

Files to Modify/Create

.forgejo/workflows/build.yml - Rewrite CI to delegate to make targets
.forgejo/workflows/release.yaml - Rewrite with build_lib.sh functions + 2-target matrix + checksums
Makefile - Add fmt-check, test-all, ci targets
scripts/build_lib.sh - Replace with canonical version (forge_config, build_binaries, publish_binaries)
.cargo/config.toml - Create; configure aarch64-linux-gnu linker

Implementation Plan

Step 1: Add missing Makefile targets

Files: Makefile

Add fmt-check target (cargo fmt --check)
Add test-all alias for test
Add ci convenience target (fmt-check, check, clippy, test)
Dependencies: none

Step 2: Replace scripts/build_lib.sh with canonical version

Files: scripts/build_lib.sh

Replace naive 22-line script with canonical version from hero_os
Provides: forge_config, build_binaries, publish_binaries, setup_linux_toolchain, cargo_env
Dependencies: none

Step 3: Create .cargo/config.toml for cross-compilation

Files: .cargo/config.toml

Configure aarch64-linux-gnu-gcc linker for aarch64-unknown-linux-gnu target
Dependencies: none

Step 4: Rewrite .forgejo/workflows/build.yml

Files: .forgejo/workflows/build.yml

Remove continue-on-error from clippy
Add fmt-check step
All steps use make targets via build_lib.sh cargo_env
Dependencies: Steps 1, 2

Step 5: Rewrite .forgejo/workflows/release.yaml

Files: .forgejo/workflows/release.yaml

2-target matrix (amd64 musl + arm64 gnu)
build_binaries + publish_binaries from build_lib.sh
sha256sum checksum generation and publishing
Dependencies: Steps 2, 3

Acceptance Criteria

make fmt-check runs cargo fmt --check
make clippy fails on warnings (no continue-on-error)
make test-all aliases make test
make ci runs full suite
build.yml does NOT contain continue-on-error
build.yml uses make fmt-check, make check, make clippy, make test
release.yaml matrix includes both x86_64-unknown-linux-musl and aarch64-unknown-linux-gnu
release.yaml calls build_binaries and publish_binaries
release.yaml generates and publishes .sha256 checksums
scripts/build_lib.sh contains forge_config, build_binaries, publish_binaries
.cargo/config.toml configures aarch64-linux-gnu linker

Notes

rusqlite bundled feature compiles SQLite from C source; aarch64 cross-compilation needs gcc-aarch64-linux-gnu
Release strategy changes from Forgejo release object to generic package registry (canonical approach)
Steps 1-3 are independent and can run in parallel

## Implementation Spec for Issue #8 ### Objective Rewrite the two Forgejo CI workflow files (build.yml and release.yaml) to align with the canonical build_lib_ci / forge-release-workflow pattern. The build workflow must delegate all CI steps to Make targets (removing continue-on-error on clippy), and the release workflow must use build_binaries / publish_binaries from scripts/build_lib.sh with a 2-target matrix (AMD64 musl + ARM64 gnu) plus SHA-256 checksum generation. ### Requirements - Build workflow: all steps invoke `make <target>` (fmt-check, clippy, test); remove continue-on-error - Release workflow: use build_lib.sh functions (forge_config, build_binaries, publish_binaries) with matrix - Matrix: x86_64-unknown-linux-musl (linux-amd64) + aarch64-unknown-linux-gnu (linux-arm64) - Add sha256sum checksum generation for every binary asset - Replace naive scripts/build_lib.sh with canonical version - Add .cargo/config.toml for aarch64 cross-compilation linker ### Files to Modify/Create - `.forgejo/workflows/build.yml` - Rewrite CI to delegate to make targets - `.forgejo/workflows/release.yaml` - Rewrite with build_lib.sh functions + 2-target matrix + checksums - `Makefile` - Add fmt-check, test-all, ci targets - `scripts/build_lib.sh` - Replace with canonical version (forge_config, build_binaries, publish_binaries) - `.cargo/config.toml` - Create; configure aarch64-linux-gnu linker ### Implementation Plan #### Step 1: Add missing Makefile targets Files: `Makefile` - Add `fmt-check` target (cargo fmt --check) - Add `test-all` alias for `test` - Add `ci` convenience target (fmt-check, check, clippy, test) Dependencies: none #### Step 2: Replace scripts/build_lib.sh with canonical version Files: `scripts/build_lib.sh` - Replace naive 22-line script with canonical version from hero_os - Provides: forge_config, build_binaries, publish_binaries, setup_linux_toolchain, cargo_env Dependencies: none #### Step 3: Create .cargo/config.toml for cross-compilation Files: `.cargo/config.toml` - Configure aarch64-linux-gnu-gcc linker for aarch64-unknown-linux-gnu target Dependencies: none #### Step 4: Rewrite .forgejo/workflows/build.yml Files: `.forgejo/workflows/build.yml` - Remove continue-on-error from clippy - Add fmt-check step - All steps use make targets via build_lib.sh cargo_env Dependencies: Steps 1, 2 #### Step 5: Rewrite .forgejo/workflows/release.yaml Files: `.forgejo/workflows/release.yaml` - 2-target matrix (amd64 musl + arm64 gnu) - build_binaries + publish_binaries from build_lib.sh - sha256sum checksum generation and publishing Dependencies: Steps 2, 3 ### Acceptance Criteria - [ ] make fmt-check runs cargo fmt --check - [ ] make clippy fails on warnings (no continue-on-error) - [ ] make test-all aliases make test - [ ] make ci runs full suite - [ ] build.yml does NOT contain continue-on-error - [ ] build.yml uses make fmt-check, make check, make clippy, make test - [ ] release.yaml matrix includes both x86_64-unknown-linux-musl and aarch64-unknown-linux-gnu - [ ] release.yaml calls build_binaries and publish_binaries - [ ] release.yaml generates and publishes .sha256 checksums - [ ] scripts/build_lib.sh contains forge_config, build_binaries, publish_binaries - [ ] .cargo/config.toml configures aarch64-linux-gnu linker ### Notes - rusqlite bundled feature compiles SQLite from C source; aarch64 cross-compilation needs gcc-aarch64-linux-gnu - Release strategy changes from Forgejo release object to generic package registry (canonical approach) - Steps 1-3 are independent and can run in parallel

ashraf commented

2026-04-23 14:25:59 +00:00

Member

Test Results

Total: 34
Passed: 34
Failed: 0
Ignored: 4 (doc-tests)

All workspace tests pass after rewriting CI workflows and Makefile targets.

Note: make fmt-check reports formatting issues in auto-generated files (osis_server_generated.rs, types_wasm_generated.rs, rpc_generated.rs). These files are regenerated by the OSchema build system and should be excluded from fmt checks or reformatted upstream.

## Test Results - Total: 34 - Passed: 34 - Failed: 0 - Ignored: 4 (doc-tests) All workspace tests pass after rewriting CI workflows and Makefile targets. Note: `make fmt-check` reports formatting issues in auto-generated files (osis_server_generated.rs, types_wasm_generated.rs, rpc_generated.rs). These files are regenerated by the OSchema build system and should be excluded from fmt checks or reformatted upstream.

ashraf commented

2026-04-23 14:26:17 +00:00

Member

Implementation Summary

Changes Made

Makefile

Added fmt-check target (cargo fmt --check)
Added test-all alias for test
Added ci convenience target running fmt-check, check, clippy, test in sequence

scripts/build_lib.sh

Replaced naive 22-line build script with canonical version from hero_os
Provides: forge_config, build_binaries, publish_binaries, setup_linux_toolchain, cargo_env, ci_setup_toolchain, and more

.cargo/config.toml (new)

Configures aarch64-linux-gnu-gcc linker for aarch64-unknown-linux-gnu cross-compilation target

.forgejo/workflows/build.yml

Replaced inline cargo commands with make fmt-check, make check, make clippy, make test
Removed continue-on-error: true from clippy step -- lint failures now break the build
Each step sources scripts/build_lib.sh and calls cargo_env for consistent PATH setup
Switched from manual git clone to actions/checkout@v4

.forgejo/workflows/release.yaml

Added build matrix: x86_64-unknown-linux-musl (linux-amd64) + aarch64-unknown-linux-gnu (linux-arm64)
Replaced inline cargo build + raw curl upload with build_binaries / publish_binaries from build_lib.sh
Added SHA-256 checksum generation and publishing for every binary
Uses setup_linux_toolchain for cross-compilation deps
Added fail-fast: false so one arch failure doesn't cancel the other

Test Results

34 passed, 0 failed, 4 ignored (doc-tests)

Notes

make fmt-check reports pre-existing formatting issues in auto-generated files (osis_server_generated.rs, etc.)
The publish_binaries function in the canonical build_lib.sh uses api/crates in the URL; the checksums step uses api/packages. Both paths should be verified against the Forgejo instance.

## Implementation Summary ### Changes Made **Makefile** - Added `fmt-check` target (`cargo fmt --check`) - Added `test-all` alias for `test` - Added `ci` convenience target running `fmt-check`, `check`, `clippy`, `test` in sequence **scripts/build_lib.sh** - Replaced naive 22-line build script with canonical version from hero_os - Provides: `forge_config`, `build_binaries`, `publish_binaries`, `setup_linux_toolchain`, `cargo_env`, `ci_setup_toolchain`, and more **.cargo/config.toml** (new) - Configures `aarch64-linux-gnu-gcc` linker for `aarch64-unknown-linux-gnu` cross-compilation target **.forgejo/workflows/build.yml** - Replaced inline cargo commands with `make fmt-check`, `make check`, `make clippy`, `make test` - Removed `continue-on-error: true` from clippy step -- lint failures now break the build - Each step sources `scripts/build_lib.sh` and calls `cargo_env` for consistent PATH setup - Switched from manual `git clone` to `actions/checkout@v4` **.forgejo/workflows/release.yaml** - Added build matrix: `x86_64-unknown-linux-musl` (linux-amd64) + `aarch64-unknown-linux-gnu` (linux-arm64) - Replaced inline `cargo build` + raw `curl` upload with `build_binaries` / `publish_binaries` from build_lib.sh - Added SHA-256 checksum generation and publishing for every binary - Uses `setup_linux_toolchain` for cross-compilation deps - Added `fail-fast: false` so one arch failure doesn't cancel the other ### Test Results - 34 passed, 0 failed, 4 ignored (doc-tests) ### Notes - `make fmt-check` reports pre-existing formatting issues in auto-generated files (osis_server_generated.rs, etc.) - The `publish_binaries` function in the canonical build_lib.sh uses `api/crates` in the URL; the checksums step uses `api/packages`. Both paths should be verified against the Forgejo instance.