refactor: simplify Settings island #137

Merged

zaelgohary merged 1 commit from development_refactor_settings_simplify into development

2026-05-11 15:09:30 +00:00

zaelgohary commented

2026-05-11 14:41:26 +00:00

Member

Summary

Trim Settings to display mode + env vars. Theme picker moved out (use the dedicated theme island). Auto-save on blur replaces per-field Save buttons. Required fields get a red left stripe + section rollup count instead of per-row Set/Missing badges. Bumps hero_osis_sdk for the JSON drift fix.

Closes #138

Changes

Stripped theme picker from Settings (16 → 5 props on MobileSettings)
Grouped env vars: Required pinned + Optional categories collapsed by default
EnvRow owns its draft + transient save state — no per-keystroke parent re-render, no clobbering refetch
Display Mode contrast fixed for both modes
Outer scroll container made full-width so blank gutter scrolls
Removed 5 unused CSS classes; added .is-missing modifier
Bumped hero_osis_sdk to 2796b03 (fixes Vec deserialization on context.list)

Test Results

Playwright: 0 console errors, save round-trip persists to overrides.env, both light/dark modes verified.

## Summary Trim Settings to display mode + env vars. Theme picker moved out (use the dedicated theme island). Auto-save on blur replaces per-field Save buttons. Required fields get a red left stripe + section rollup count instead of per-row Set/Missing badges. Bumps hero_osis_sdk for the JSON drift fix. ## Related Issue Closes #138 ## Changes - Stripped theme picker from Settings (16 → 5 props on MobileSettings) - Grouped env vars: Required pinned + Optional categories collapsed by default - EnvRow owns its draft + transient save state — no per-keystroke parent re-render, no clobbering refetch - Display Mode contrast fixed for both modes - Outer scroll container made full-width so blank gutter scrolls - Removed 5 unused CSS classes; added .is-missing modifier - Bumped hero_osis_sdk to 2796b03 (fixes Vec<String> deserialization on context.list) ## Test Results Playwright: 0 console errors, save round-trip persists to overrides.env, both light/dark modes verified.

zaelgohary added 1 commit

2026-05-11 14:41:26 +00:00