lhumina_code/hero_osis

Fork 0

chore: remove hero_bot — unused ACP agent binary #28

Open

timur wants to merge 1 commit from fix/buildenv-drop-hero-bot into development

timur commented

2026-04-20 10:38:00 +00:00

Owner

What changed

Remove the hero_bot binary entirely from hero_osis. It was an ACP-compatible agent that executed Hero Osis workflows over stdio — it required the ai and flow features, both of which are explicitly WIP and gated out of all-domains.

Nobody was building it by default. Its only practical effect on the repo was causing the symptomatic cargo produced no release binary for: hero_bot error that Kristof hit, because BINARIES in buildenv.sh still listed it while cargo silently skipped it (required-features not enabled).

Rather than carry two coupled stale-feature-gate workarounds, drop the binary.

Changes

Delete crates/hero_osis_server/src/bin/hero_bot.rs
Remove the [[bin]] name = "hero_bot" entry from crates/hero_osis_server/Cargo.toml
Remove hero_bot from BINARIES in buildenv.sh

Source preservation

Archived on branch archive/hero-bot-acp, pinned at the development tip immediately before this PR. When/if ai+flow graduate out of WIP and there's a real user for the ACP agent path, cherry-pick from there.

Test plan

cargo check --workspace --features all-domains green
Kristof's original error no longer possible — hero_bot is not in BINARIES and does not exist as a target

🤖 Generated with Claude Code

## What changed Remove the `hero_bot` binary entirely from hero_osis. It was an ACP-compatible agent that executed Hero Osis workflows over stdio — it required the `ai` and `flow` features, both of which are explicitly WIP and gated out of `all-domains`. Nobody was building it by default. Its only practical effect on the repo was causing the symptomatic `cargo produced no release binary for: hero_bot` error that Kristof hit, because `BINARIES` in `buildenv.sh` still listed it while cargo silently skipped it (required-features not enabled). Rather than carry two coupled stale-feature-gate workarounds, drop the binary. ## Changes - Delete `crates/hero_osis_server/src/bin/hero_bot.rs` - Remove the `[[bin]] name = "hero_bot"` entry from `crates/hero_osis_server/Cargo.toml` - Remove `hero_bot` from `BINARIES` in `buildenv.sh` ## Source preservation Archived on branch `archive/hero-bot-acp`, pinned at the development tip immediately before this PR. When/if ai+flow graduate out of WIP and there's a real user for the ACP agent path, cherry-pick from there. ## Test plan - [x] `cargo check --workspace --features all-domains` green - [x] Kristof's original error no longer possible — `hero_bot` is not in `BINARIES` and does not exist as a target 🤖 Generated with [Claude Code](https://claude.com/claude-code)

timur added 1 commit

2026-04-20 10:38:00 +00:00

fix(buildenv): drop hero_bot from BINARIES — depends on gated ai/flow

Build and Test / build (pull_request) Successful in 7m37s

Details

a7c8ce0f52

`hero_bot` requires the `ai` and `flow` features (Cargo.toml:
`required-features = ["ai", "flow"]`). Those features were gated
out of `all-domains` in 2b4a1f4 while the domains are still under
development — but BINARIES wasn't updated to match.

Symptom: `cargo build --features all-domains` finishes clean, then
`verify_binaries` errors with "cargo produced no release binary
for: hero_bot" because cargo silently skipped it (required-features
not enabled).

Drop hero_bot from the default BINARIES list. Build it on demand:

    cargo build --release --bin hero_bot --features "ai,flow"

When ai/flow graduate out of WIP and re-enter `all-domains`, add
hero_bot back here.

timur force-pushed fix/buildenv-drop-hero-bot from a7c8ce0f52

Build and Test / build (pull_request) Successful in 7m37s

Details

to e0012f2864

Build and Test / build (pull_request) Successful in 5m40s

Details

2026-04-20 12:45:37 +00:00

Compare

timur changed title from ~~fix(buildenv): drop hero_bot — depends on gated ai/flow features~~ to chore: remove hero_bot — unused ACP agent binary

2026-04-20 12:45:49 +00:00

Build and Test / build (pull_request) Successful in 5m40s

Details

This pull request has changes conflicting with the target branch.

buildenv.sh
crates/hero_osis_server/src/bin/hero_bot.rs

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin fix/buildenv-drop-hero-bot:fix/buildenv-drop-hero-bot

git switch fix/buildenv-drop-hero-bot

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff fix/buildenv-drop-hero-bot

git switch fix/buildenv-drop-hero-bot

git rebase development

git switch development

git merge --ff-only fix/buildenv-drop-hero-bot

git switch fix/buildenv-drop-hero-bot

git rebase development

git switch development

git merge --no-ff fix/buildenv-drop-hero-bot

git switch development

git merge --squash fix/buildenv-drop-hero-bot