lhumina_code/hero_osis
21
0
Fork 0
Code Issues 2 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix: correct ClientError import path in generated SDK clients #7

Closed
mik-tf wants to merge 1 commit from development_offline_import into development
pull from: development_offline_import
merge into: lhumina_code:development
Conversation 0 Commits 1 Files changed 17 +17 -17
mik-tf commented 2026-02-14 18:36:45 +00:00
Owner
Copy link

Summary

  • Fix all 17 osis_client_generated.rs files to use herolib_osis::offline::ClientError instead of herolib_osis::offline::transport::ClientError
  • The transport sub-module is not publicly accessible from herolib_osis::offline
  • These files were generated with the bug fixed in https://forge.ourworld.tf/lhumina_code/hero_lib — the generator fix should be merged first to prevent re-generation from reverting this

Closes #6

## Summary - Fix all 17 `osis_client_generated.rs` files to use `herolib_osis::offline::ClientError` instead of `herolib_osis::offline::transport::ClientError` - The `transport` sub-module is not publicly accessible from `herolib_osis::offline` - These files were generated with the bug fixed in https://forge.ourworld.tf/lhumina_code/hero_lib — the generator fix should be merged first to prevent re-generation from reverting this Closes #6
fix: correct ClientError import path in generated SDK clients
Some checks failed
Build and Test / build (pull_request) Failing after 1m45s
Details
f7c15a072d 
Change herolib_osis::offline::transport::ClientError to
herolib_osis::offline::ClientError across all 17 domain clients.
The offline module re-exports ClientError directly.

Closes #6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mik-tf closed this pull request 2026-02-15 14:14:51 +00:00
Some checks failed
Build and Test / build (pull_request) Failing after 1m45s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_osis!7
No description provided.