lhumina_code/hero_proc
2
0
Fork 0
Code Issues 25 Pull requests Projects Releases 3 Packages Wiki Activity Actions

feat(secrets): register HERO_DB_PORT in the canonical catalogue #132

Merged
nabil_salah merged 2 commits from feat/secrets-catalogue-hero-db-port into main 2026-06-03 11:32:17 +00:00
Conversation 2 Commits 2 Files changed 2 +14
nabil_salah commented 2026-06-02 14:44:12 +00:00
Member
Copy link

Add HERO_DB_PORT (hero_db RESP2 TCP port, default 6378) to the secrets catalogue
so hero_proc auto-registers it on startup — visible in lab secrets and sourced
by hero_db from the store instead of OS env, matching MAIL_PORT / POSTGRES_PORT.
Adds entries to KNOWN_SECRET_KEYS (keys.rs), the SECRETS_TEMPLATE [hero_db]
section, and the canonical descriptions/tags map (rpc/secret.rs).

Verified: deleting the secret and restarting hero_proc re-registers HERO_DB_PORT
(catalogue total 76 -> 77, context core, tag hero_db).

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Add HERO_DB_PORT (hero_db RESP2 TCP port, default 6378) to the secrets catalogue so hero_proc auto-registers it on startup — visible in `lab secrets` and sourced by hero_db from the store instead of OS env, matching MAIL_PORT / POSTGRES_PORT. Adds entries to KNOWN_SECRET_KEYS (keys.rs), the SECRETS_TEMPLATE [hero_db] section, and the canonical descriptions/tags map (rpc/secret.rs). Verified: deleting the secret and restarting hero_proc re-registers HERO_DB_PORT (catalogue total 76 -> 77, context core, tag hero_db). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(secrets): register HERO_DB_PORT in the canonical catalogue
Some checks failed
Build and Test / build (pull_request) Waiting to run
Details
Tests / test (pull_request) Has been cancelled
Details
4c2de41bf0 
Add HERO_DB_PORT (hero_db RESP2 TCP port, default 6378) to the secrets catalogue
so hero_proc auto-registers it on startup — visible in `lab secrets` and sourced
by hero_db from the store instead of OS env, matching MAIL_PORT / POSTGRES_PORT.
Adds entries to KNOWN_SECRET_KEYS (keys.rs), the SECRETS_TEMPLATE [hero_db]
section, and the canonical descriptions/tags map (rpc/secret.rs).

Verified: deleting the secret and restarting hero_proc re-registers HERO_DB_PORT
(catalogue total 76 -> 77, context core, tag hero_db).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Merge branch 'development' into feat/secrets-catalogue-hero-db-port
Some checks failed
Build and Test / build (pull_request) Has been cancelled
Details
e3a2dd7e05
mahmoud approved these changes 2026-06-02 15:21:42 +00:00
mahmoud commented 2026-06-02 15:21:53 +00:00
Owner
Copy link

Please merge after green CI

Please merge after green CI
Merge branch 'development' into feat/secrets-catalogue-hero-db-port
Some checks failed
Build and Test / build (pull_request) Failing after 2m1s
Details
e00c921bb1
nabil_salah changed target branch from development to main 2026-06-03 10:05:45 +00:00
nabil_salah force-pushed feat/secrets-catalogue-hero-db-port from e00c921bb1
Some checks failed
Build and Test / build (pull_request) Failing after 2m1s
Details
to e4f7baced0
All checks were successful
Build and Test / build (pull_request) Successful in 23m7s
Details
2026-06-03 10:15:23 +00:00 Compare
Merge remote-tracking branch 'origin/main' into feat/secrets-catalogue-hero-db-port
Some checks failed
Build and Test / build (pull_request) Failing after 25m34s
Details
f0755b594b 
# Conflicts:
#	crates/hero_proc_server/src/secrets/keys.rs
Sign in to join this conversation.
Reviewers
No reviewers
mahmoud
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_proc!132
No description provided.