fix(router): preserve percent-encoding in forward_path #62

Merged

zaelgohary merged 1 commit from development_fix_router_percent_encoding into development

2026-04-27 14:14:30 +00:00

zaelgohary commented

2026-04-27 14:11:36 +00:00

Member

Summary

hero_router worker threads were panicking on any URL whose path contains percent-encoded characters (e.g. %20). service_proxy_path derived forward_path from axum's Path<(String, String, String)> extractor, which percent-decodes — so Data%20Mining... became Data Mining... (raw spaces) and hyperlocal's URI builder rejected it with InvalidUriChar.

Fix derives forward_path from the raw req.uri().path() and strips the /<service>/<webname>/ prefix, preserving encoding all the way to the upstream UDS request.

Closes #61

Changes

crates/hero_router/src/server/routes.rs — service_proxy_path builds forward_path from raw URI

Test Results

cargo fmt --check ✅
cargo check --workspace ✅
cargo clippy --workspace -- -D warnings ✅
cargo test --workspace 79/79 ✅

Manual verification

curl -i 'http://127.0.0.1:9988/hero_office/ui/pdf/edit/Data%20Mining%20Lab%20Two-1.pdf?context=geomind' returns 200 with the expected HTML; no InvalidUriChar panics in router stderr.

## Summary hero_router worker threads were panicking on any URL whose path contains percent-encoded characters (e.g. `%20`). `service_proxy_path` derived `forward_path` from axum's `Path<(String, String, String)>` extractor, which percent-decodes — so `Data%20Mining...` became `Data Mining...` (raw spaces) and hyperlocal's URI builder rejected it with `InvalidUriChar`. Fix derives `forward_path` from the raw `req.uri().path()` and strips the `/<service>/<webname>/` prefix, preserving encoding all the way to the upstream UDS request. ## Related Issue Closes #61 ## Changes - `crates/hero_router/src/server/routes.rs` — `service_proxy_path` builds forward_path from raw URI ## Test Results - `cargo fmt --check` ✅ - `cargo check --workspace` ✅ - `cargo clippy --workspace -- -D warnings` ✅ - `cargo test --workspace` 79/79 ✅ ## Manual verification `curl -i 'http://127.0.0.1:9988/hero_office/ui/pdf/edit/Data%20Mining%20Lab%20Two-1.pdf?context=geomind'` returns 200 with the expected HTML; no `InvalidUriChar` panics in router stderr.

zaelgohary added 1 commit

2026-04-27 14:11:37 +00:00