fix(dev): bump hero_proc_sdk + fix RequestContext test #27

Open

timur wants to merge 1 commit from fix/dev-build-proc-sdk-bump into development

timur commented

2026-04-20 10:56:54 +00:00

Owner

Why

development doesn't compile right now. Two small drifts:

1. `Cargo.lock` pinned old hero_proc_sdk

Commit 784b411 added inputs: None on JobCreateInput in crates/service/src/lifecycle.rs:290. The inputs field was added to hero_proc_sdk::JobCreateInput upstream — but the lockfile was never bumped, so cargo resolved the old sha (8e7e985) where the field didn't exist yet.

error[E0560]: struct `JobCreateInput` has no field named `inputs`
  --> crates/service/src/lifecycle.rs:290:17

Fix: cargo update -p hero_proc_sdk → e847693 (current dev tip).

2. Test missed a field add

Commit 7d14133 added hero_context_name: Option<String> to RequestContext. test_serde_roundtrip uses struct-literal init and wasn't updated — E0063 on cargo check --tests.

error[E0063]: missing field `hero_context_name` in initializer of `request_context::RequestContext`
  --> crates/osis/src/rpc/request_context.rs:296:19

Fix: add hero_context_name: None to the test literal.

After

cargo check --workspace green
cargo check --workspace --tests green
cargo test --workspace --lib — 266 passed, 0 failed, 1 ignored

Scope

Two files: Cargo.lock and crates/osis/src/rpc/request_context.rs. No logic changes.

🤖 Generated with Claude Code

## Why `development` doesn't compile right now. Two small drifts: ### 1. `Cargo.lock` pinned old hero_proc_sdk Commit 784b411 added `inputs: None` on `JobCreateInput` in `crates/service/src/lifecycle.rs:290`. The `inputs` field was added to `hero_proc_sdk::JobCreateInput` upstream — but the lockfile was never bumped, so cargo resolved the old sha (`8e7e985`) where the field didn't exist yet. ``` error[E0560]: struct `JobCreateInput` has no field named `inputs` --> crates/service/src/lifecycle.rs:290:17 ``` Fix: `cargo update -p hero_proc_sdk` → `e847693` (current dev tip). ### 2. Test missed a field add Commit 7d14133 added `hero_context_name: Option<String>` to `RequestContext`. `test_serde_roundtrip` uses struct-literal init and wasn't updated — E0063 on `cargo check --tests`. ``` error[E0063]: missing field `hero_context_name` in initializer of `request_context::RequestContext` --> crates/osis/src/rpc/request_context.rs:296:19 ``` Fix: add `hero_context_name: None` to the test literal. ## After - [x] `cargo check --workspace` green - [x] `cargo check --workspace --tests` green - [x] `cargo test --workspace --lib` — **266 passed, 0 failed, 1 ignored** ## Scope Two files: `Cargo.lock` and `crates/osis/src/rpc/request_context.rs`. No logic changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

timur added 1 commit

2026-04-20 10:56:54 +00:00

fix(dev): bump hero_proc_sdk + fix test missing hero_context_name

Test / test (pull_request) Successful in 1m29s

Details

aaa9c20280

Two small drifts on development that broke the build:

1. Cargo.lock pinned hero_proc_sdk at 8e7e985 — before the `inputs`
   field was added to `JobCreateInput`. Commit 784b411 introduced
   `inputs: None` in `crates/service/src/lifecycle.rs:290`, but the
   lockfile was never bumped, so cargo resolved the old sha and the
   field didn't exist: E0560 "struct JobCreateInput has no field
   named 'inputs'". Running `cargo update -p hero_proc_sdk` bumps
   to e847693 (latest dev tip).

2. `test_serde_roundtrip` in request_context.rs constructs
   `RequestContext` struct-literal-style but was never updated when
   commit 7d14133 added the `hero_context_name: Option<String>`
   field — E0063 "missing field hero_context_name". Add it (None).

After both fixes:
- `cargo check --workspace` green
- `cargo check --workspace --tests` green
- `cargo test --workspace --lib` — 266 passed, 0 failed, 1 ignored

Test / test (pull_request) Successful in 1m29s

Details

This pull request has changes conflicting with the target branch.

Cargo.lock

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin fix/dev-build-proc-sdk-bump:fix/dev-build-proc-sdk-bump

git switch fix/dev-build-proc-sdk-bump

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development

git merge --no-ff fix/dev-build-proc-sdk-bump

git switch fix/dev-build-proc-sdk-bump

git rebase development

git switch development

git merge --ff-only fix/dev-build-proc-sdk-bump

git switch fix/dev-build-proc-sdk-bump

git rebase development

git switch development

git merge --no-ff fix/dev-build-proc-sdk-bump

git switch development

git merge --squash fix/dev-build-proc-sdk-bump