lhumina_code/hero_services
23
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix/docker-build-all-services #12

Closed
delandtj wants to merge 3 commits from fix/docker-build-all-services into development
pull from: fix/docker-build-all-services
merge into: lhumina_code:development
Conversation 1 Commits 3 Files changed 16 +60 -19
delandtj commented 2026-02-12 10:07:32 +00:00
Member
Copy link
No description provided.
fix: Docker build failures for service installation
Some checks are pending
Build and Test / build (pull_request) Waiting to run
Details
3366d6fc18
 
- Add libseccomp-dev and libcap-ng-dev to builder stage (zinit link deps)
- Add optional build.cmd field for services without make install targets
- Add optional build.binary field for correct install tracking
- Remove CARGO_TARGET_DIR from service builds (broke Makefile target paths)
- Ensure dirs exist in _InstallService before writing tracking info
- Add custom build commands for hero_forge, hero_runner, hero_supervisor, mycelium
- Fix hero_aibroker binary name detection (exec starts with sh -c)
- Pin builder/runtime to rust:bookworm / debian:bookworm-slim (glibc match)
- Add libseccomp-dev, libcap-ng-dev to builder (zinit link deps)
- Fail fast on service build errors (set -e, no more || skip)
- Add build.cmd and build.binary fields to service config schema
- All services use direct cargo build commands (bypass build_lib.sh/rustup)
- Use $RELEASE_DIR for binary paths, respects CARGO_TARGET_DIR for caching
- Fix binary names: hero_indexer→heroindex, heroforge→heroforge-server,
  hero_runner, hero_supervisor, hero_compute_manager→compute
- Remove stale development_auth branch ref from hero_books
- Print repo URL, branch, and build cmd during install-service
- Ensure dirs exist in _InstallService handler
Merge branch 'fix/docker-build-failures' into fix/docker-build-all-services
Some checks failed
Build and Test / build (pull_request) Failing after 2s
Details
46a068181a
 
# Conflicts:
#	services/hero_aibroker.toml
#	services/hero_forge.toml
#	services/hero_runner.toml
#	services/hero_supervisor.toml
#	services/mycelium.toml
#	src/main.rs
timur commented 2026-02-20 10:31:30 +00:00
Owner
Copy link

Closing — useful parts integrated, rest handled differently

Took the valuable parts into development:

Integrated

  • build.binary field — explicit binary name for install tracking when binary ≠ service name (e.g. hero_aibroker → aibroker). → 53eb8ca
  • Dockerfile deps (libseccomp-dev, libcap-ng-dev) — already present in our Dockerfile
  • paths.ensure_dirs() — already called in setup() before install

Not taken (different approach)

  • build.cmd — instead of teaching hero_zero custom build commands, repos should follow the build_lib convention documented as a skill (buildenv.sh + Makefile with make install). hero_forge already does this. hero_coordinator needs the build_lib treatment separately.
  • env_remove("CARGO_TARGET_DIR") — build_lib's RELEASE_DIR already resolves correctly when CARGO_TARGET_DIR is set. Shared cache is valuable.

All 44 tests pass. Branch can be deleted.

## Closing — useful parts integrated, rest handled differently Took the valuable parts into `development`: ### Integrated - **`build.binary` field** — explicit binary name for install tracking when binary ≠ service name (e.g. hero_aibroker → aibroker). → `53eb8ca` - **Dockerfile deps** (`libseccomp-dev`, `libcap-ng-dev`) — already present in our Dockerfile - **`paths.ensure_dirs()`** — already called in `setup()` before install ### Not taken (different approach) - **`build.cmd`** — instead of teaching hero_zero custom build commands, repos should follow the build_lib convention documented as a skill (buildenv.sh + Makefile with `make install`). hero_forge already does this. hero_coordinator needs the build_lib treatment separately. - **`env_remove("CARGO_TARGET_DIR")`** — build_lib's `RELEASE_DIR` already resolves correctly when `CARGO_TARGET_DIR` is set. Shared cache is valuable. All 44 tests pass. Branch can be deleted.
timur closed this pull request 2026-02-20 10:31:30 +00:00
Some checks failed
Build and Test / build (pull_request) Failing after 2s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_services!12
No description provided.