fix(web): stamp explicit incomplete/stop_reason instead of UI prose matching #96

Open

salmaelsoly wants to merge 1 commit from development_structured_incomplete_field into integration

pull from: development_structured_incomplete_field

merge into: lhumina_code:integration

lhumina_code:integration

lhumina_code:int_fix_veridict

lhumina_code:development

lhumina_code:development_freeze

lhumina_code:port-from-xmoncode-shrimp

lhumina_code:main

lhumina_code:development_kristof

lhumina_code:development_comply

Conversation 0 Commits 1 Files changed 9 +142 -14

salmaelsoly commented 2026-06-08 14:23:57 +00:00

Member

Copy link

Summary

Replaces the UI's brittle prose-matching (isIncompleteReply() over ~8 hardcoded phrases) with an explicit incomplete (boolean) / stop_reason (string) field stamped by the server on every turn/job reply. The UI keys its Continue/Retry affordance off that field and falls back to the prose heuristic only when the field is absent (older daemon). Detection reuses existing server-side signals — no new prose matcher.

Related Issue

Closes #40

Changes

• Server (proof_run.rs): new turn_incomplete_signal() — the single server-owned text fallback, reusing reply_indicates_incomplete_run() (no new phrases).
• Server (session.rs): stamp incomplete/stop_reason on the synchronous message.send response and the chat.complete SSE event.
• Engine (core.rs): stamp incomplete/stop_reason on the turn:end SSE event, matched against the engine-owned STEP_LIMIT_REPLY_MARKER; Err arm reports stop_reason: "error".
• Server (contract.rs): stamp_incomplete_signal_into_details() derives the signal from the structured step-limit flag, then failure_kind, then the reply fallback; called at the proof/autonomy job-details persistence point and during subagent reconciliation (before failure_kind is cleared).
• UI (store.ts): prefer the server field at all 3 call sites (trackJobUntilDone terminal, sync message.send return, turn:end SSE); isIncompleteReply() demoted to a documented legacy fallback. Regenerated production bundle.
• Tests: 4 new unit tests covering turn_incomplete_signal() and stamp_incomplete_signal_into_details() (structured flag, failure_kind, clean run).

Test Results

cargo test -p hero_shrimp_server — 301 passed, 0 failed. cargo check -p hero_shrimp_engine -p hero_shrimp_server clean. vite build succeeded; tsc shows only pre-existing unrelated errors.

## Summary Replaces the UI's brittle prose-matching (`isIncompleteReply()` over ~8 hardcoded phrases) with an explicit `incomplete` (boolean) / `stop_reason` (string) field stamped by the server on every turn/job reply. The UI keys its Continue/Retry affordance off that field and falls back to the prose heuristic only when the field is absent (older daemon). Detection reuses existing server-side signals — no new prose matcher. ## Related Issue Closes https://forge.ourworld.tf/lhumina_code/hero_shrimp/issues/40 ## Changes - **Server (`proof_run.rs`)**: new `turn_incomplete_signal()` — the single server-owned text fallback, reusing `reply_indicates_incomplete_run()` (no new phrases). - **Server (`session.rs`)**: stamp `incomplete`/`stop_reason` on the synchronous `message.send` response and the `chat.complete` SSE event. - **Engine (`core.rs`)**: stamp `incomplete`/`stop_reason` on the `turn:end` SSE event, matched against the engine-owned `STEP_LIMIT_REPLY_MARKER`; `Err` arm reports `stop_reason: "error"`. - **Server (`contract.rs`)**: `stamp_incomplete_signal_into_details()` derives the signal from the structured step-limit flag, then `failure_kind`, then the reply fallback; called at the proof/autonomy job-details persistence point and during subagent reconciliation (before `failure_kind` is cleared). - **UI (`store.ts`)**: prefer the server field at all 3 call sites (`trackJobUntilDone` terminal, sync `message.send` return, `turn:end` SSE); `isIncompleteReply()` demoted to a documented legacy fallback. Regenerated production bundle. - **Tests**: 4 new unit tests covering `turn_incomplete_signal()` and `stamp_incomplete_signal_into_details()` (structured flag, `failure_kind`, clean run). ## Test Results `cargo test -p hero_shrimp_server` — 301 passed, 0 failed. `cargo check -p hero_shrimp_engine -p hero_shrimp_server` clean. `vite build` succeeded; `tsc` shows only pre-existing unrelated errors.

salmaelsoly added 1 commit 2026-06-08 14:23:59 +00:00

fix(web): stamp explicit incomplete/stop_reason instead of UI prose matching ... 3482b99ccc

Replace the UI's brittle prose-matching (isIncompleteReply over ~8 hardcoded
phrases) with an explicit incomplete/stop_reason field stamped by the server on
every turn/job reply. The UI keys its Continue/Retry affordance off that field
and falls back to the prose heuristic only when the field is absent (older
daemon). Detection reuses existing server signals — the structured step-limit
event, failure_kind, and a single server-owned reply_indicates_incomplete_run
fallback — so there is no new prose matcher.

#40

salmaelsoly referenced this pull request 2026-06-08 14:24:32 +00:00

[P1] isIncompleteReply() relies on 7 hardcoded magic strings #40

salmaelsoly force-pushed development_structured_incomplete_field from 3482b99ccc to f6c9572a2d 2026-06-08 14:25:56 +00:00 Compare

All checks were successful

Hide all checks

Verify / verify (pull_request) Successful in 12m47s

Details

Verify / verify (push) Successful in 32m54s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin development_structured_incomplete_field:development_structured_incomplete_field

git switch development_structured_incomplete_field

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch integration

git merge --no-ff development_structured_incomplete_field

git switch development_structured_incomplete_field

git rebase integration

git switch integration

git merge --ff-only development_structured_incomplete_field

git switch development_structured_incomplete_field

git rebase integration

git switch integration

git merge --no-ff development_structured_incomplete_field

git switch integration

git merge --squash development_structured_incomplete_field

git switch integration

git merge --ff-only development_structured_incomplete_field

git switch integration

git merge development_structured_incomplete_field

git push origin integration

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

prio_critical

  

prio_low

  

type_bug

  

type_contact

  

type_issue

  

type_lead

  

type_question

  

type_story

  

type_task

No labels

prio_critical

prio_low

type_bug

type_contact

type_issue

type_lead

type_question

type_story

type_task

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

lhumina_code/hero_shrimp!96

No description provided.