cleanup(service_office): slim nu module to canonical shape #142

Merged

zaelgohary merged 1 commit from development_cleanup_slim_service_office into development

2026-04-27 11:32:55 +00:00

zaelgohary commented

2026-04-27 10:36:20 +00:00

Member

Summary

Mirrors the slim shape of service_voice.nu (the canonical reference: 123 lines). Most of service_office.nu's bulk was stale prose, a non-load-bearing preflight, and forwarding of OO_SERVER_URL which no service reads anymore.

Closes #141

Changes

tools/modules/services/service_office.nu — 324 → 135 lines (-189 LoC). Drops top-of-file prose, OO_SERVER_URL forwarding, svx_check_foundry preflight, and verbose start summary.

Test Results

N/A (nu module). Smoke verified by exec-driven start.

Manual verification

service_office stop then service_office start (slim module) registers actions and brings hero_office up healthy.
hero_proc service status hero_office → running.
HERO_OS_URL=http://127.0.0.1:9988/hero_os/ui/ npx playwright test office_editor_real 4/4 ✅.

## Summary Mirrors the slim shape of `service_voice.nu` (the canonical reference: 123 lines). Most of `service_office.nu`'s bulk was stale prose, a non-load-bearing preflight, and forwarding of `OO_SERVER_URL` which no service reads anymore. ## Related Issue Closes #141 ## Changes - `tools/modules/services/service_office.nu` — 324 → 135 lines (-189 LoC). Drops top-of-file prose, `OO_SERVER_URL` forwarding, `svx_check_foundry` preflight, and verbose start summary. ## Test Results N/A (nu module). Smoke verified by exec-driven start. ## Manual verification - `service_office stop` then `service_office start` (slim module) registers actions and brings hero_office up healthy. - `hero_proc service status hero_office` → running. - `HERO_OS_URL=http://127.0.0.1:9988/hero_os/ui/ npx playwright test office_editor_real` 4/4 ✅.

zaelgohary added 1 commit

2026-04-27 10:36:20 +00:00

cleanup(service_office): slim nu module to canonical shape (135 lines)

Build and Publish Skills / build-and-publish (pull_request) Successful in 3s

Details

32d6d0fbb6

Mirrors the service_voice.nu shape: imports + constants + two action
builders + four exported commands.

Drops:
- 50+ lines of prose comments (stale notes about hero_zero TOML, the
  scripts/nu_service.nu mirror that no longer exists, deviation table)
- `OO_SERVER_URL` from forwarded env in both actions (no service reads
  it anymore — matches the post-cleanup hero_office binaries)
- `svx_check_foundry` soft-dep preflight (foundry absence is noticed
  at first RPC call and recoverable; not load-bearing)
- Verbose ship-house summary in `start` — replaced with a 2-line
  pointer matching the convention in service_voice.nu

Net: 324 → 135 lines (-189 LoC).