feat(service_livekit): per-user livekit ports via hero_cfg.toml [livekit] #176

Merged

sameh-farouk merged 2 commits from feat/livekit-per-user-ports-auto into development

2026-04-30 04:45:32 +00:00

sameh-farouk commented

2026-04-30 02:09:43 +00:00

Member

Closes #175. Supersedes #174 (which is now closed — the forward-compat 1-liner from that PR is folded into this single commit).

Companion to hero_livekit#34.

Summary

Single file changed (tools/modules/services/service_livekit.nu). Two coordinated edits:

New helper svx_lk_read_hero_cfg_livekit — reads [livekit] section from ~/hero/cfg/hero_cfg.toml, returns {} if missing.
svx_lk_install_and_configure reads the section once and passes the values (with 0 fallback for missing fields) into cfg_params's livekit_port / rtc_tcp_port / backend_port.

Makes service_livekit.nu both (a) forward-compatible with hero_livekit#34's required rtc_tcp_port param, and (b) per-user-aware via cfg.toml.

Architecture

hero_cfg.toml is the durable per-user source. Already carries [mycelium]; adding [livekit] follows the existing pattern (service_router.nu / service_collab.nu read sections from the same file).
runtime.json is correctly modeled as a derived cache. The wipe in svx_lk_wipe_stale_configs stays untouched — it correctly forces a clean slate on inconsistency. Per-user values survive wipes because the next service_livekit start re-reads hero_cfg.toml and re-derives runtime.json from there.

An earlier draft (#174) considered preserving runtime.json across wipes — that was the wrong layer to fix it and was dropped.

Behavior

Scenario	hero_cfg.toml `[livekit]`	Result
Single-user install (today)	absent	Defaults 7880 / 7881 / 8081. Unchanged.
Multi-user user without `[livekit]`	absent	Defaults — collides if sibling is also on defaults. Operator must add the section.
Multi-user with `[livekit]` per user	present, non-overlapping triples	Values flow: cfg.toml → configure RPC → runtime.json → yaml → livekit-server bind. Survives wipes.

Operator workflow on a multi-user box

# /home/alice/hero/cfg/hero_cfg.toml
[mycelium]
bridge_name = "br-alice"
ipv6_address = "..."

[livekit]
livekit_port = 7890
rtc_tcp_port = 7891
backend_port = 8091

Then service_livekit start and never touch it again.

Compatibility matrix with hero_livekit binary versions

service_livekit.nu	hero_livekit binary	configure RPC works?
old	old	✓
old	new (#34)	✗ Missing required parameter
this PR	old	✓ extra field ignored by old serde
this PR	new (#34)	✓

Land this PR at-or-before the hero_livekit binary is upgraded on operator boxes.

What's intentionally NOT in this PR

An allocator that auto-writes the [livekit] section. The section is operator-managed today; if a tool to allocate non-overlapping triples becomes useful, it can be added as a separate small helper (e.g. hero_user_livekit_alloc <user>) — kept OUT of multi_user_add, which is mycelium-focused and shouldn't carry livekit-specific allocation logic.

Test plan

service_livekit start with no [livekit] section: defaults apply, single-user setup unchanged
service_livekit start with [livekit] section: values flow into configure RPC → runtime.json → yaml → livekit-server bind
service_livekit start --reset (which wipes runtime.json): next start re-reads cfg.toml [livekit], values reconstructed
Two users coexist on dev box (138.201.206.39): sameh + ashraf with non-overlapping port triples

Closes #175. Supersedes #174 (which is now closed — the forward-compat 1-liner from that PR is folded into this single commit). Companion to [hero_livekit#34](https://forge.ourworld.tf/lhumina_code/hero_livekit/pulls/34). ## Summary Single file changed (`tools/modules/services/service_livekit.nu`). Two coordinated edits: 1. **New helper `svx_lk_read_hero_cfg_livekit`** — reads `[livekit]` section from `~/hero/cfg/hero_cfg.toml`, returns `{}` if missing. 2. **`svx_lk_install_and_configure`** reads the section once and passes the values (with `0` fallback for missing fields) into `cfg_params`'s `livekit_port` / `rtc_tcp_port` / `backend_port`. Makes service_livekit.nu both (a) forward-compatible with hero_livekit#34's required `rtc_tcp_port` param, and (b) per-user-aware via cfg.toml. ## Architecture - `hero_cfg.toml` is the durable per-user source. Already carries `[mycelium]`; adding `[livekit]` follows the existing pattern (`service_router.nu` / `service_collab.nu` read sections from the same file). - `runtime.json` is correctly modeled as a derived cache. The wipe in `svx_lk_wipe_stale_configs` stays untouched — it correctly forces a clean slate on inconsistency. Per-user values survive wipes because the next `service_livekit start` re-reads `hero_cfg.toml` and re-derives runtime.json from there. An earlier draft (#174) considered preserving runtime.json across wipes — that was the wrong layer to fix it and was dropped. ## Behavior | Scenario | hero_cfg.toml `[livekit]` | Result | |---|---|---| | Single-user install (today) | absent | Defaults 7880 / 7881 / 8081. **Unchanged.** | | Multi-user user without `[livekit]` | absent | Defaults — collides if sibling is also on defaults. Operator must add the section. | | Multi-user with `[livekit]` per user | present, non-overlapping triples | Values flow: cfg.toml → configure RPC → runtime.json → yaml → livekit-server bind. Survives wipes. | ## Operator workflow on a multi-user box ```toml # /home/alice/hero/cfg/hero_cfg.toml [mycelium] bridge_name = "br-alice" ipv6_address = "..." [livekit] livekit_port = 7890 rtc_tcp_port = 7891 backend_port = 8091 ``` Then `service_livekit start` and never touch it again. ## Compatibility matrix with hero_livekit binary versions | service_livekit.nu | hero_livekit binary | configure RPC works? | |---|---|---| | old | old | ✓ | | old | new (#34) | ✗ Missing required parameter | | **this PR** | old | ✓ extra field ignored by old serde | | **this PR** | new (#34) | ✓ | Land this PR at-or-before the hero_livekit binary is upgraded on operator boxes. ## What's intentionally NOT in this PR An allocator that auto-writes the `[livekit]` section. The section is operator-managed today; if a tool to allocate non-overlapping triples becomes useful, it can be added as a separate small helper (e.g. `hero_user_livekit_alloc <user>`) — kept OUT of `multi_user_add`, which is mycelium-focused and shouldn't carry livekit-specific allocation logic. ## Test plan - [x] `service_livekit start` with no `[livekit]` section: defaults apply, single-user setup unchanged - [x] `service_livekit start` with `[livekit]` section: values flow into configure RPC → runtime.json → yaml → livekit-server bind - [x] `service_livekit start --reset` (which wipes runtime.json): next start re-reads cfg.toml `[livekit]`, values reconstructed - [x] Two users coexist on dev box (138.201.206.39): sameh + ashraf with non-overlapping port triples

sameh-farouk force-pushed feat/livekit-per-user-ports-auto from 5500b7b10e to 489b49d584

2026-04-30 02:14:46 +00:00

Compare

sameh-farouk changed title from ~~feat(service_livekit): read [livekit] section from hero_cfg.toml for per-user ports~~ to feat(service_livekit): per-user livekit ports via hero_cfg.toml [livekit]

2026-04-30 02:16:52 +00:00

sameh-farouk changed target branch from feat/livekit-per-user-ports-compat to development

2026-04-30 02:16:53 +00:00

sameh-farouk referenced this pull request

2026-04-30 02:18:01 +00:00

feat(service_livekit): forward-compat with hero_livekit configure RPC #174

sameh-farouk referenced this pull request

2026-04-30 02:18:02 +00:00

service_livekit.nu: forward-compat with hero_livekit configure RPC change #173

sameh-farouk added 1 commit

2026-04-30 04:44:11 +00:00