lhumina_code/hero_skills
4
0
Fork 0
Code Issues 34 Pull requests Projects Releases 1 Packages 1 Wiki Activity Actions

feat: implement service editor #179

Merged
mahmoud merged 1 commit from develop_service_editor into development 2026-04-30 10:19:00 +00:00
Conversation 0 Commits 1 Files changed 2 +353
nabil_salah commented 2026-04-30 09:48:31 +00:00
Member
Copy link

Smoke test results

Check Expected Actual Status
start --reset runs end-to-end install → register → start → summary All steps printed; state: running ✅
service_editor status running state: running, pid: 1908616, restarts: 0 ✅
Server Unix socket bound ~/hero/var/sockets/hero_editor_server.sock srwxrwxr-x at exactly that path ✅
UI HTTP responds 200 on GET / HTTP 200 ✅
Action script field correct both binaries get --content-dir <path> Confirmed via ps -ef ✅
WebDAV warning fires "DEFAULT password 'admin'" line in summary Printed correctly ✅
TODO marker visible above the ui-url print Wasn't printed (it's a code comment, not output) — that's fine ✅

The summary lines match reality on every claim the module makes.

- https://forge.ourworld.tf/lhumina_code/hero_skills/issues/156 ## Smoke test results | Check | Expected | Actual | Status | | --- | --- | --- | --- | | `start --reset` runs end-to-end | install → register → start → summary | All steps printed; `state: running` | ✅ | | `service_editor status` | running | `state: running, pid: 1908616, restarts: 0` | ✅ | | Server Unix socket bound | `~/hero/var/sockets/hero_editor_server.sock` | `srwxrwxr-x` at exactly that path | ✅ | | UI HTTP responds | 200 on `GET /` | `HTTP 200` | ✅ | | Action `script` field correct | both binaries get `--content-dir <path>` | Confirmed via `ps -ef` | ✅ | | WebDAV warning fires | `"DEFAULT password 'admin'"` line in summary | Printed correctly | ✅ | | TODO marker visible | above the ui-url print | Wasn't printed (it's a code comment, not output) — that's fine | ✅ | The summary lines match reality on every claim the module makes.
feat: implement service editor
All checks were successful
Build and Publish Skills / build-and-publish (pull_request) Successful in 3s
Details
09a862301e 
Signed-off-by: Nabil-Salah <nabil.salah203@gmail.com>
mahmoud merged commit 3ffea31506 into development 2026-04-30 10:19:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_skills!179
No description provided.