ci(lab-publish): build under rustc 1.96 (lab + herolib require it) #314

Closed

sameh-farouk wants to merge 0 commits from development_sameh_labci into development

sameh-farouk commented

2026-06-04 18:39:49 +00:00

Member

What

The lab publish workflow installed + defaulted to rustc 1.95, but lab and the herolib_* crates now require 1.96, so every publish run on development fails:

rustc 1.95.0 is not supported by the following packages:
  herolib_core@0.6.0  requires rustc 1.96
  herolib_ai@0.6.0    requires rustc 1.96
  lab@0.1.0           requires rustc 1.96
  ...

Fix

rustup toolchain install/default → 1.96
add job-level RUSTUP_TOOLCHAIN: "1.96" (cargo precedence: +toolchain > RUSTUP_TOOLCHAIN > rust-toolchain.toml > rustup default) so both cargo install lab and lab build --workspace use 1.96, and it stays robust if a rust-toolchain.toml is ever added.

This is the same fix already applied to hero_livekit's publish CI (verified green there). hero_skills has no rust-toolchain.toml, so the bump + env are sufficient.

Note

Pre-existing infra breakage (every development publish run failing since the herolib 0.6.0 / 1.96 bump) — orthogonal to feature work. Merge gate is yours.

## What The `lab publish` workflow installed + defaulted to **rustc 1.95**, but `lab` and the `herolib_*` crates now require **1.96**, so every publish run on `development` fails: ``` rustc 1.95.0 is not supported by the following packages: herolib_core@0.6.0 requires rustc 1.96 herolib_ai@0.6.0 requires rustc 1.96 lab@0.1.0 requires rustc 1.96 ... ``` ## Fix - `rustup toolchain install/default` → **1.96** - add job-level `RUSTUP_TOOLCHAIN: "1.96"` (cargo precedence: `+toolchain > RUSTUP_TOOLCHAIN > rust-toolchain.toml > rustup default`) so both `cargo install lab` and `lab build --workspace` use 1.96, and it stays robust if a `rust-toolchain.toml` is ever added. This is the same fix already applied to hero_livekit's publish CI (verified green there). hero_skills has no `rust-toolchain.toml`, so the bump + env are sufficient. ## Note Pre-existing infra breakage (every `development` publish run failing since the herolib 0.6.0 / 1.96 bump) — orthogonal to feature work. Merge gate is yours.

sameh-farouk added 1 commit

2026-06-04 18:39:49 +00:00

ci(lab-publish): build under rustc 1.96 (lab + herolib require it)

lab publish / publish (push) Has been cancelled

Details

03ee89bdb3

The publish workflow installed + defaulted to rustc 1.95, but lab and the
herolib_* crates now require 1.96:

    rustc 1.95.0 is not supported by the following packages:
      herolib_core@0.6.0 requires rustc 1.96
      lab@0.1.0          requires rustc 1.96
      ...

Bump 'rustup toolchain install/default' to 1.96 and add a job-level
RUSTUP_TOOLCHAIN=1.96 (cargo precedence: +toolchain > RUSTUP_TOOLCHAIN >
rust-toolchain.toml > rustup default) so both 'cargo install lab' and
'lab build --workspace' use 1.96, and it stays robust if a
rust-toolchain.toml is added later. Every publish run on development has
been failing on this since the herolib 0.6.0 / 1.96 bump.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

sameh-farouk commented

2026-06-04 18:45:47 +00:00

Author

Member

Pushed directly to development (03ee89b) and cherry-picked to main (ded240d) per request; closing this PR. Follow-up install.sh MSRV fix also landed on both branches.

Pushed directly to `development` (03ee89b) and cherry-picked to `main` (ded240d) per request; closing this PR. Follow-up install.sh MSRV fix also landed on both branches.