lhumina_code/hero_archipelagos
21
0
Fork 0
Code Issues 8 Pull requests 3 Projects Releases Packages Wiki Activity Actions

feat: inline PDF preview in filesystem island #20

Open
mik-tf wants to merge 1 commit from development_pdf_preview into development
pull from: development_pdf_preview
merge into: lhumina_code:development
Conversation 0 Commits 1 Files changed 1 +149
mik-tf commented 2026-02-19 13:28:55 +00:00
Owner
Copy link

Summary

  • When opening a PDF file in the filesystem island, shows an inline preview using an iframe instead of opening a new browser tab
  • Adds a PdfPreview component with back button, filename display, and open-in-new-tab button
  • Both file double-click and context menu "Open" are handled
  • Non-PDF files continue to open in new tabs as before

Closes #19

Test plan

  • Open a PDF file in the filesystem island — should show inline preview
  • Click back arrow — should return to file browser
  • Click open-in-new-tab icon — should open PDF in new browser tab
  • Open a non-PDF file — should still open in new tab as before
  • Right-click > Open on a PDF — should show inline preview
## Summary - When opening a PDF file in the filesystem island, shows an inline preview using an iframe instead of opening a new browser tab - Adds a `PdfPreview` component with back button, filename display, and open-in-new-tab button - Both file double-click and context menu "Open" are handled - Non-PDF files continue to open in new tabs as before Closes #19 ## Test plan - [ ] Open a PDF file in the filesystem island — should show inline preview - [ ] Click back arrow — should return to file browser - [ ] Click open-in-new-tab icon — should open PDF in new browser tab - [ ] Open a non-PDF file — should still open in new tab as before - [ ] Right-click > Open on a PDF — should show inline preview
feat: inline PDF preview in filesystem island
Some checks failed
Build and Test / build (pull_request) Failing after 40s
Details
37380cf4c8 
When opening a PDF file, show an inline preview within the island
using an iframe instead of opening in a new browser tab.

Closes #19
Some checks failed
Build and Test / build (pull_request) Failing after 40s
Details
This pull request has changes conflicting with the target branch.
  • archipelagos/files/src/island.rs
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin development_pdf_preview:development_pdf_preview
git switch development_pdf_preview

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch development
git merge --no-ff development_pdf_preview
git switch development_pdf_preview
git rebase development
git switch development
git merge --ff-only development_pdf_preview
git switch development_pdf_preview
git rebase development
git switch development
git merge --no-ff development_pdf_preview
git switch development
git merge --squash development_pdf_preview
git switch development
git merge --ff-only development_pdf_preview
git switch development
git merge development_pdf_preview
git push origin development
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_archipelagos!20
No description provided.