lhumina_code/hero_osis
1
0
Fork 0
Code Issues 11 Pull requests Projects Releases 3 Packages Wiki Activity Actions

refactor: trim env registry #56

Merged
zaelgohary merged 1 commit from development_refactor_env_registry_trim into development 2026-05-11 15:08:18 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -37
zaelgohary commented 2026-05-11 14:41:32 +00:00
Member
Copy link

Summary

Drop env vars that don't belong in user-facing Settings. SSO Auth tokens are auto-populated by login; Search keys are a Hero-internal AI feature; TFGrid mnemonic is admin-only. GITHUB_TOKEN belongs alongside GIT_NAME/GIT_EMAIL under Identity.

Related Issue

Closes #57

Changes

  • Removed TF_VAR_mnemonic (Grid category)
  • Removed SERPER_API_KEYS, EXA_API_KEYS (Search category)
  • Removed HERO_AUTH_CLIENT_ID, HERO_AUTH_CLIENT_SECRET (Auth category)
  • Moved GITHUB_TOKEN: Infrastructure → Identity

Test Results

config.env_list returns 16 vars in 5 categories. hero_os Settings UI verified after registry change.

## Summary Drop env vars that don't belong in user-facing Settings. SSO Auth tokens are auto-populated by login; Search keys are a Hero-internal AI feature; TFGrid mnemonic is admin-only. GITHUB_TOKEN belongs alongside GIT_NAME/GIT_EMAIL under Identity. ## Related Issue Closes #57 ## Changes - Removed TF_VAR_mnemonic (Grid category) - Removed SERPER_API_KEYS, EXA_API_KEYS (Search category) - Removed HERO_AUTH_CLIENT_ID, HERO_AUTH_CLIENT_SECRET (Auth category) - Moved GITHUB_TOKEN: Infrastructure → Identity ## Test Results config.env_list returns 16 vars in 5 categories. hero_os Settings UI verified after registry change.
refactor: trim env registry — drop Grid/Search/Auth, move GITHUB_TOKEN to Identity
Some checks failed
Build Linux / build-linux (x86_64-unknown-linux-musl, false, x86_64-unknown-linux-musl) (push) Failing after 3s
Details
Build Linux / build-linux (x86_64-unknown-linux-musl, false, x86_64-unknown-linux-musl) (pull_request) Failing after 3s
Details
Build and Test / build (push) Successful in 8m20s
Details
Build and Test / build (pull_request) Successful in 8m23s
Details
a2683da703
zaelgohary merged commit 62f82b2386 into development 2026-05-11 15:08:18 +00:00
zaelgohary deleted branch development_refactor_env_registry_trim 2026-05-11 15:08:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
prio_critical

   
prio_low

   
type_bug

   
type_contact

   
type_issue

   
type_lead

   
type_question

   
type_story

   
type_task
No labels
prio_critical
prio_low
type_bug
type_contact
type_issue
type_lead
type_question
type_story
type_task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
lhumina_code/hero_osis!56
No description provided.